fix(slm): add ansible_name column for proper Ansible targeting (#1814)

autobot-slm-backend/api/nodes.py

@@ -432,6 +432,7 @@ async def create_node(
     node = Node(
         node_id=node_id,
         hostname=node_data.hostname,
+        ansible_name=node_data.ansible_name,  # Issue #1814
         ip_address=node_data.ip_address,
         roles=node_data.roles,
         ssh_user=node_data.ssh_user,
@@ -1395,6 +1396,7 @@ async def replace_node(
     new_node = Node(
         node_id=new_node_id,
         hostname=node_data.hostname,
+        ansible_name=node_data.ansible_name,  # Issue #1814
         ip_address=node_data.ip_address,
         roles=node_data.roles,
         ssh_user=node_data.ssh_user,

autobot-slm-backend/api/services.py

@@ -375,9 +375,10 @@ async def scan_node_services(
         from services.playbook_executor import get_playbook_executor
 
         executor = get_playbook_executor()
+        ansible_target = node.ansible_target  # #1814
         result = await executor.execute_playbook(
             playbook_name="discover-services.yml",
-            limit=[node.hostname],
+            limit=[ansible_target],
         )
 
         if not result.get("success"):
@@ -388,7 +389,7 @@ async def scan_node_services(
         # Extract service facts from Ansible result
         # service_facts returns ansible_facts.services as a dict
         services_data = (
-            result.get("facts", {}).get(node.hostname, {}).get("services", {})
+            result.get("facts", {}).get(ansible_target, {}).get("services", {})
         )
 
         if not services_data:

autobot-slm-backend/api/setup_wizard.py

@@ -184,7 +184,8 @@ async def _generate_dynamic_inventory(
             }
             if node.ssh_port and node.ssh_port != 22:
                 host_vars["ansible_port"] = node.ssh_port
-            hosts[node.hostname] = host_vars
+            inventory_name = node.ansible_target  # #1814
+            hosts[inventory_name] = host_vars
             node_id_to_hostname[node.node_id] = node.hostname
             node_id_to_ip[node.node_id] = node.ip_address
 

autobot-slm-backend/api/tls.py

@@ -1017,9 +1017,10 @@ async def _execute_cert_deployment(
     if chain_path:
         extra_vars["chain_file"] = chain_path
 
+    ansible_target = node.ansible_target  # #1814
     result = await executor.execute_playbook(
         playbook_name="deploy-certificate.yml",
-        limit=[node.hostname],
+        limit=[ansible_target],
         extra_vars=extra_vars,
     )
 

autobot-slm-backend/migrations/add_node_ansible_name.py

@@ -0,0 +1,29 @@
+# AutoBot - AI-Powered Automation Platform
+# Copyright (c) 2025 mrveiss
+# Author: mrveiss
+"""
+Migration: Add ansible_name column to nodes table (#1814).
+
+The hostname column stores user-facing display names (e.g., '00-SLM-Manager')
+which are unsuitable for Ansible --limit and SSH operations. This adds an
+explicit ansible_name column for Ansible inventory host targeting, with
+ip_address fallback for nodes where it is not set.
+"""
+
+import logging
+
+from migrations.utils import add_column_if_not_exists, get_connection
+
+logger = logging.getLogger(__name__)
+
+
+def migrate(db_url: str) -> None:
+    """Add ansible_name column to nodes table (#1814)."""
+    conn = get_connection(db_url)
+    cursor = conn.cursor()
+
+    add_column_if_not_exists(cursor, "nodes", "ansible_name", "VARCHAR(255)")
+
+    conn.commit()
+    conn.close()
+    logger.info("Migration: added ansible_name column to nodes")

autobot-slm-backend/migrations/runner.py

@@ -54,6 +54,8 @@
     # Issue #1900: consolidate slm_users (integer PK) into users (UUID PK)
     # and drop the now-orphaned slm_users table.
     "consolidate_slm_users_to_uuid",
+    # Issue #1814: add ansible_name column for proper Ansible targeting
+    "add_node_ansible_name",
 ]
 
 

autobot-slm-backend/models/database.py

@@ -96,6 +96,7 @@ class Node(Base):
     id = Column(Integer, primary_key=True, autoincrement=True)
     node_id = Column(String(64), unique=True, nullable=False, index=True)
     hostname = Column(String(255), nullable=False)
+    ansible_name = Column(String(255), nullable=True)  # Issue #1814
     ip_address = Column(String(45), nullable=False)
     status = Column(String(20), default=NodeStatus.PENDING.value)
     roles = Column(JSON, default=list)
@@ -129,6 +130,11 @@ class Node(Base):
     created_at = Column(DateTime, default=datetime.utcnow)
     updated_at = Column(DateTime, default=datetime.utcnow, onupdate=datetime.utcnow)
 
+    @property
+    def ansible_target(self) -> str:
+        """Best identifier for Ansible --limit targeting (#1814)."""
+        return self.ansible_name or self.ip_address
+
 
 class Deployment(Base):
     """Deployment model for tracking role deployments."""

autobot-slm-backend/models/schemas.py

@@ -136,6 +136,7 @@ class NodeCreate(BaseModel):
     """Node registration request."""
 
     hostname: str
+    ansible_name: Optional[str] = None  # Ansible inventory name (#1814)
     ip_address: str
     node_id: Optional[
         str
@@ -153,6 +154,7 @@ class NodeUpdate(BaseModel):
     """Node update request."""
 
     hostname: Optional[str] = None
+    ansible_name: Optional[str] = None  # Ansible inventory name (#1814)
     ip_address: Optional[str] = None
     status: Optional[NodeStatus] = None
     roles: Optional[List[str]] = None
@@ -164,6 +166,7 @@ class NodeResponse(BaseModel):
     id: int
     node_id: str
     hostname: str
+    ansible_name: Optional[str] = None  # Ansible inventory name (#1814)
     ip_address: str
     status: str
     roles: Optional[List[str]] = []

autobot-slm-backend/services/reconciler.py

@@ -16,6 +16,7 @@
 from datetime import datetime, timedelta
 from typing import Dict, List, Optional
 
+from config import settings
 from models.database import (
     Deployment,
     DeploymentStatus,
@@ -33,8 +34,6 @@
 from sqlalchemy import select
 from sqlalchemy.ext.asyncio import AsyncSession
 
-from config import settings
-
 logger = logging.getLogger(__name__)
 
 # Role to systemd service mapping
@@ -471,9 +470,10 @@ async def _remediate_node(self, db: AsyncSession, node: Node) -> bool:
             message=f"Attempting to restart SLM agent on {node.hostname}",
         )
 
-        # Try to restart the SLM agent via Ansible
+        # Try to restart the SLM agent via Ansible (#1814: prefer ansible_name)
+        ansible_target = node.ansible_target
         success = await self._restart_service_via_ansible(
-            node.hostname,
+            ansible_target,
             "slm-agent",
         )
 
@@ -757,9 +757,10 @@ async def _remediate_failed_service(
             message=f"Attempting to restart {service.service_name} on {node.hostname}",
         )
 
-        # Try to restart via Ansible
+        # Try to restart via Ansible (#1814: prefer ansible_name)
+        ansible_target = node.ansible_target
         success = await self._restart_service_via_ansible(
-            node.hostname,
+            ansible_target,
             service.service_name,
         )