fix(security): harden VNC to require password authentication (#1939, #1940)#1941
Merged
mrveiss merged 2 commits intoDev_new_guifrom Mar 20, 2026
Merged
fix(security): harden VNC to require password authentication (#1939, #1940)#1941mrveiss merged 2 commits intoDev_new_guifrom
mrveiss merged 2 commits intoDev_new_guifrom
Conversation
…1939) All VNC scripts/templates previously used -SecurityTypes None with --I-KNOW-THIS-IS-INSECURE, allowing unauthenticated remote desktop access to anyone on the network. Changes: - browser-vnc.service: switch to VncAuth,TLSVnc + add passwd check - setup_browser_vnc.sh: add VNC password verification step, use VncAuth - start-isolated-vnc.sh: use VncAuth, fix stale IP, add passwd check - .gitignore: un-ignore docker/certs/ for tracked scripts (#1940)
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
- vnc_manager.py: replace SecurityTypes None with VncAuth,TLSVnc (this is the main runtime path when users open noVNC tab) - fix-vnc-desktop.sh: replace hardcoded "kali" password with random generation via openssl rand (accepts VNC_PASSWORD env var override) - fix-vnc-wsl.sh: same hardcoded password removal
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 3 VNC scripts/templates in the repo used
-SecurityTypes None --I-KNOW-THIS-IS-INSECURE, allowing unauthenticated remote desktop access to anyone on the network.Changes
browser-vnc.servicesetup_browser_vnc.shstart-isolated-vnc.sh192.168.168.17.gitignorecerts/blocksdocker/certs/!docker/certs/negation (#1940)Security details
VncAuth,TLSVnc(password + optional TLS)~/.vnc/passwdexists before starting VNCsetup_browser_vnc.shprompts to create password if missingCloses #1939
Closes #1940
Test plan
browser-vnc.servicefails to start without~/.vnc/passwdsetup_browser_vnc.sh— confirm it prompts for passwordstart-isolated-vnc.sh— confirm password required to connectgit add docker/certs/generate-self-signed.shworks without-f