fix: resolve all 25 agent-bom skill audit findings#11
Merged
Conversation
Fixes all findings from the agent-bom skills scan CI run: 1. missing_source (8 findings): Added homepage + source URL to all 8 SKILL.md frontmatter metadata blocks. Users can now verify publisher and audit source code. 2. unverifiable_claim (8 findings): Source URLs now provide verifiable evidence for read-only claims. Each skill links directly to its source directory on GitHub. 3. undeclared_dependency (3 findings): Added optional_bins for docker and kubectl to discover-environment and gpu-cluster-security SKILL.md files where those tools are referenced in instructions. 4. credential_file_access (1 finding): Replaced inline 'aws secretsmanager get-secret-value' command in examples.md with a placeholder + comment directing users to their own secrets manager. Raw credential retrieval commands should not appear in skill instruction files. All fixes follow Anthropic skill spec best practices: - metadata.homepage and metadata.source for publisher verification - optional_bins for referenced but non-required CLI tools - No raw credential access commands in instruction files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 25 findings from the agent-bom
skills scanCI run.homepage+sourceURL to all SKILL.md metadataoptional_binsfor docker/kubectlaws secretsmanagerwith placeholderAll fixes follow Anthropic skill spec best practices.
Test plan