Mavenbuild #2
Mavenbuild #2
Conversation
mschoettle
left a comment
mschoettle
left a comment
There was a problem hiding this comment.
Thanks!
Just a few minor things. And please capitalize Eclipse, Maven and Ant :)
README.md
Outdated
| Alternatively: ```cd mt4j-core; ant create_run_jar``` | ||
| * This generates a new file, for further use as MT4J-library: **mt4j-core/mt4j.jar** | ||
|
|
||
| > *Note:* Unfortunately the ant build requires the compiled classes in a ```bin```subfolder (Created by eclipse: ```clean & build```). So you can not avoid eclipse. |
There was a problem hiding this comment.
I don't mind if we make this non-Eclipse specific. Would you be willing to add an ANT task that compiles the sources first?
There was a problem hiding this comment.
I have little experience with ant and would have to get into it first. It's probably more efficient if you modify the existing ant task.
| ### Mavenize it | ||
|
|
||
| * To build a local maven artifact, based on this jar: | ||
| ```mvn install:install-file -Dfile=mt4j.jar -DgroupId=friend.of.mcgillsel -DartifactId=mt4j -Dversion=mspatch-1.0 -Dpackaging=jar -DcreateChecksum=true``` |
There was a problem hiding this comment.
Is friend.of.... as the group ID required? Otherwise just use ca.mcgill.sel
There was a problem hiding this comment.
I hesitate to use ca.mcgill.sel. Usually the groupId are the source-authors (who we are not). So it would be misleading to use our own id here. On the other hand it would be bold to use the signature of mt4j's official authors. I found it best to indicate in the signature that it is related to our work at sel/mcgill, but unofficial.
| ### Mavenize it | ||
|
|
||
| * To build a local maven artifact, based on this jar: | ||
| ```mvn install:install-file -Dfile=mt4j.jar -DgroupId=friend.of.mcgillsel -DartifactId=mt4j -Dversion=mspatch-1.0 -Dpackaging=jar -DcreateChecksum=true``` |
There was a problem hiding this comment.
Why is the version set as mspatch-1.0?
There was a problem hiding this comment.
Just an indicator, that it is a patched version of the original mt4j, and that it is the first maven release. Have another one in the queue, that would then become 1.1 etc...
Added detailed project setup instructions to README, including an additional wrap-up of the generated MT4J jar as a local maven artifact, for easy integration in external maven projects.