Lesson7 #7
Open
Lesson7 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…я методы помеченные как @test, затем метод с аннотацией @AfterSuite.
OKrylov
approved these changes
Mar 27, 2019
OKrylov
left a comment
OKrylov
left a comment
There was a problem hiding this comment.
Все отлично, отсутствует только приоритет тестовых методов
| } | ||
| } | ||
| if (beforeCount > 1 || afterCount > 1) { | ||
| throw new RuntimeException(); |
There was a problem hiding this comment.
при бросании своих исключений всегда описывайте причину ошибки, чтобы потом легче было понимать её
| } | ||
| } | ||
|
|
||
| private static void startMethodWithBeforeSuiteAnnotation(Class clazz, Method[] methods) { |
There was a problem hiding this comment.
3 одинаковых метода, отличаются лишь типом аннотации. Лучше использовать один обобщенный метод, где обобщение - тип аннотации
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.