Rust: disable mingw packaging via configuration option #17777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mati865
force-pushed
the
simplify-rust-packaging
branch
2 times, most recently
from
a768a47 to
3b19c7c
Compare
mati865
force-pushed
the
simplify-rust-packaging
branch
from
3b19c7c to
706daae
Compare
mati865
changed the title
Member
|
thanks! |
Member
|
Looks like this broke things (in staging): https://github.com/msys2/msys2-tests/actions/runs/5768428800 Should I revert? |
lazka
added a commit
that referenced
this pull request
Aug 5, 2023
This reverts commit 706daae. This results in a broken rust (or some other change since the last rebuild): error: linking with `x86_64-w64-mingw32-clang` failed: exit code: 1 note: x86_64-w64-mingw32-clang: error: no such file or directory: 'crt2.o' See #17777 (comment)
Member
|
Reverted via 1717c9e for now |
Collaborator
Author
|
Sorry, looks like we cannot get rid of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One less downstream patch to maintain (once the fix reaches the release....).
Upstream PR: rust-lang/rust#113725