Skip to content

Conversation

@Kreijstal
Copy link
Contributor

Adding support for this, some workarounds were taken in order to compile with mingw but we finally have mysqldump as well.

couldn't build it for clang

Adding support for this, some workarounds were taken in order to compile with mingw
but we finally have mysqldump as well
@Kreijstal Kreijstal changed the title new: mariadbl-clients new: mariadb-clients Nov 13, 2025
@striezel
Copy link
Collaborator

striezel commented Nov 14, 2025

Nice! 👍

Just out of curiosity: Is the huge patch file based on some existing code/issue/pull request? I'm asking because it contains a comment referring to "CONC-789", which is the ID of a ticket on MariaDB's Jira instance (https://jira.mariadb.org/browse/CONC-789). And such a big patch file (almost 1700 lines) would be quite a nightmare to maintain, because it will likely need to be refreshed on every update.

@striezel striezel added the new-package Pull request which adds new package(s) label Nov 14, 2025
@Kreijstal
Copy link
Contributor Author

Nice! 👍

Just out of curiosity: Is the huge patch file based on some existing code/issue/pull request? I'm asking because it contains a comment referring to "CONC-789", which is the ID of a ticket on MariaDB's Jira instance (https://jira.mariadb.org/browse/CONC-789). And such a big patch file (almost 1700 lines) would be quite a nightmare to maintain, because it will likely need to be refreshed on every update.

I didn't think I'd bother, since I didn't believe anyone at mariadb cares about compiling with mingw, if that is the case I could prepare a more focused patch. however the process of rebasing shouldn't be too exhausting too mantain since it is mostly condition headers.

@striezel
Copy link
Collaborator

Two things:

  • Has anyone had the chance to do some tests with the artifacts from the CI? For example, can one connect with mariadb.exe to a MariaDB instance and issue a few queries? Does the mariadb-dump.exe create a correct DB dump? And so on.
  • There is pkgrel=2 in the PKGBUILD, but it should start at 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-package Pull request which adds new package(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants