Skip to content

expose heatsinkable_nodes#88

Open
The4codeblocks wants to merge 9 commits intomt-mods:masterfrom
The4codeblocks:patch-2
Open

expose heatsinkable_nodes#88
The4codeblocks wants to merge 9 commits intomt-mods:masterfrom
The4codeblocks:patch-2

Conversation

@The4codeblocks
Copy link
Contributor

fixes #79

@wsor4035
Copy link

wsor4035 commented Jan 12, 2026

I would do the group as the issue suggests

@OgelGames
Copy link
Contributor

Also can we change the name of the file to heatsink.lua?

@wsor4035
Copy link

Also can we change the name of the file to heatsink.lua?

seems vastly out of scope and probably should be its own commit rather than bundled in

@The4codeblocks
Copy link
Contributor Author

I'm getting a weird problem on mineunit testing

@S-S-X
Copy link
Member

S-S-X commented Jan 12, 2026

I'm getting a weird problem on mineunit testing

Initialization test assumes that usual / common are not enabled, basically in this case there's now hard dependency on luacontroller which is why sillystuff.lua:10: attempt to index field '?' (a nil value) happens (no luac available).

@S-S-X
Copy link
Member

S-S-X commented Jan 12, 2026

Maybe luac and mooncontroller should also use groups instead of getting special treatment?
(I mean create PR for those mods instead of overriding it here).

@The4codeblocks
Copy link
Contributor Author

Maybe luac and mooncontroller should also use groups instead of getting special treatment? (I mean create PR for those mods instead of overriding it here).

hm

so I have a PR on mooncontroller for that (mt-mods/mooncontroller#7)

I'll work on the mesecons/luac side

The4codeblocks added a commit to The4codeblocks/mesecons that referenced this pull request Jan 12, 2026
@S-S-X
Copy link
Member

S-S-X commented Jan 17, 2026

Should digistuff actually require mesecons_luacontroller as hard dependency?
And then possibly availability checks disabled (in case heatsinkable group wont be accepted at minetest-mods) and luac nodedef fixture added for tests, or even mod pulled in for testing, if overrides stay.

@The4codeblocks
Copy link
Contributor Author

is there any case where mesecons should be expected to exist without mesecons_luacontroller?

@SwissalpS
Copy link
Contributor

yes

@The4codeblocks
Copy link
Contributor Author

The4codeblocks commented Jan 30, 2026

So, this is digistuff which needs digilines,
which aren't very useful without a luac.
(and yes I know that the IOexpander can take mesecon input)

@The4codeblocks
Copy link
Contributor Author

Should digistuff actually require mesecons_luacontroller as hard dependency?

decided by #89's closure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it easier for other mods to make nodes compatible with heatsink.

5 participants