Make tp tubes use mod storage with prefixed keys#179
Merged
wsor4035 merged 3 commits intomt-mods:masterfrom Dec 25, 2025
Merged
Make tp tubes use mod storage with prefixed keys#179wsor4035 merged 3 commits intomt-mods:masterfrom
wsor4035 merged 3 commits intomt-mods:masterfrom
Conversation
Contributor
Author
|
Whoops, just found a bug with negative z coordinates. Position hashes lose precision when converted to string. Fixing this in a minute ^^" |
Contributor
|
Edit: nvm this part, mod storage doesn't work like that
In essence I'm looking for a way to minimize string manipulations. Unfortunately the storage api doesn't seem to allow us to use an entirely separate storage object. |
BuckarooBanzay
approved these changes
Dec 25, 2025
Member
BuckarooBanzay
left a comment
BuckarooBanzay
left a comment
There was a problem hiding this comment.
lgtm, didn't test though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change every call to
storage:*to use prefixed keys. Also cleans up previous prefix-less keys upon migrating.It is worth noting that this might inadvertently erase keys set by other parts of Pipeworks if those keys happen to match the position hash of an existing teleport tube. But I assume that it won't happen, because I trust that nobody will use prefix-less keys in future extensions of Pipeworks.
Fixes #177.