-
Notifications
You must be signed in to change notification settings - Fork 51
Prevent seg faults when not all fields are present #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…vent seg faults on asian ips
|
@mtodd Any word here? I'm encountering this in production, and it isn't pretty. |
|
+1 |
|
Have the same issue - scottrutherford's commits fix the issue. Please merge! |
|
Sorry for the delay on this, but the changes to the tests were really bugging me. Check out the pull request #9: the tests aren't all passing yet but will be as soon as I hear back from MaxMind. |
|
+1 |
|
+1 Just discovered this one on our production servers. nasty stuff. |
|
This also hit our servers, this is a really nasty bug and shouldn't wait for MaxMind. |
|
Any chance we could get some movement on this? I hate to fork and roll our own, but that is certainly better than seeing segmentation faults on our servers. |
Using the latest version of the full database there are IP's (specifically Asian, Hong Kong in test) that don't have all fields. This method was causing issues encode_to_utf8_and_return_rb_str