Skip to content

Conversation

@scottrutherford
Copy link

Using the latest version of the full database there are IP's (specifically Asian, Hong Kong in test) that don't have all fields. This method was causing issues encode_to_utf8_and_return_rb_str

@ab
Copy link

ab commented Jun 20, 2012

@mtodd Any word here? I'm encountering this in production, and it isn't pretty.

@findchris
Copy link
Contributor

+1

@ippy04
Copy link

ippy04 commented Jul 5, 2012

Have the same issue - scottrutherford's commits fix the issue. Please merge!

@mtodd
Copy link
Owner

mtodd commented Jul 11, 2012

Sorry for the delay on this, but the changes to the tests were really bugging me. Check out the pull request #9: the tests aren't all passing yet but will be as soon as I hear back from MaxMind.

@ami-navon
Copy link

+1
This bugfix is much appreciated.
For example, the following snippet causes segmentation fault on geoip-c 0.8.1, but not on geoip-c 0.8.0:

$ irb
require 'geoip'
geoip = GeoIP::City.new('/tmp/GeoLiteCity.dat', :memory)
puts geoip.look_up("203.131.232.110")
# => On geoip 0.8.0: {:country_code=>"HK", :country_code3=>"HKG", :country_name=>"Hong Kong", :region=>"00", :city=>"Central District", :latitude=>22.283300399780273, :longitude=>114.1500015258789}
# => On geoip 0.8.1: SEGMENTATION FAULT 

@goosetav
Copy link

+1

Just discovered this one on our production servers. nasty stuff.

@MikeEmery
Copy link

This also hit our servers, this is a really nasty bug and shouldn't wait for MaxMind.

@gorism
Copy link

gorism commented Apr 15, 2013

Any chance we could get some movement on this? I hate to fork and roll our own, but that is certainly better than seeing segmentation faults on our servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants