Open
Conversation
yousifS
reviewed
Dec 7, 2018
| return true; | ||
| } | ||
| } | ||
| //if selected piece is white check if move is legal |
There was a problem hiding this comment.
Your isLegalWhite and isLegalBlack are very similar. Could you have had 1 method and just passed in a variable that indicated if it was white or black?
yousifS
reviewed
Dec 7, 2018
| { | ||
| //checks if piece is moving left | ||
| bool movingLeft = MovingLeft(columnStart, columnTo); | ||
| if(//columnTo and rowTo is empty and piece is not moving to same row and column |
There was a problem hiding this comment.
that if condition is a little hard to read. maybe using variable to hold each "thing" you are testing, or having multiple if statements?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.