Skip to content

Add a extracting method with success and failure block#1

Open
zetachang wants to merge 2 commits intomuccy:masterfrom
zetachang:feature/add_extracting_class_method
Open

Add a extracting method with success and failure block#1
zetachang wants to merge 2 commits intomuccy:masterfrom
zetachang:feature/add_extracting_class_method

Conversation

@zetachang
Copy link

No description provided.

@muccy
Copy link
Owner

muccy commented Aug 24, 2012

Hi,
thanks for your code.

Isn't it better to use a single completion block, following the class design? What is more, I think that is not a good idea to return the extractor object is a shorthand method like that (not useful to have a reference, the object is not fully init'd because of the lack of completionBlock)...

I think more about a signature like:
+ (void)extractYouTubeURL:(NSURL *)youTubeURL videoQuality:(LBYouTubeVideoQuality)videoQuality completion:(void(^)(NSURL *extractedURL, NSError *error))completionBlock

Bye

@zetachang
Copy link
Author

Hi,
Thank you for replying so quickly.

I just come from the original project (https://github.com/larcus94/LBYouTubeViewand) seeking for just a simple extractor and find your fork is actively maintained.

I think the one you suggest is just fine. I'll fix it later : )

@muccy
Copy link
Owner

muccy commented Aug 24, 2012

Thanks again: we'll find a good solution and we will integrate you idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants