Add a extracting method with success and failure block#1
Add a extracting method with success and failure block#1zetachang wants to merge 2 commits intomuccy:masterfrom
Conversation
|
Hi, Isn't it better to use a single completion block, following the class design? What is more, I think that is not a good idea to return the extractor object is a shorthand method like that (not useful to have a reference, the object is not fully init'd because of the lack of completionBlock)... I think more about a signature like: Bye |
|
Hi, I just come from the original project (https://github.com/larcus94/LBYouTubeViewand) seeking for just a simple extractor and find your fork is actively maintained. I think the one you suggest is just fine. I'll fix it later : ) |
|
Thanks again: we'll find a good solution and we will integrate you idea :) |
No description provided.