[BH-1776] USB charging fixes #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dawidwojtas-mudita
left a comment
dawidwojtas-mudita
left a comment
There was a problem hiding this comment.
Good job! The code is well written.
Please take a look at a few minor remarks we left, mainly stylistic.
Lefucjusz
reviewed
Mar 27, 2024
Member
Lefucjusz
left a comment
Lefucjusz
left a comment
There was a problem hiding this comment.
Additionally, please change the title of the PR and corresponding commit so that it complies to the standard used in our company, which is [BH-xxx] What is introduced by this commit, where xxx is our internal tracking number. In case of this task this should be BH-1776, so the title would be something like [BH-1776] USB charging fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device charging fix
Mudita-Harmony [2302B] by Grinn