dedent: stop stripping spaces after a line's first non-space rune#85
Open
c-tonneslan wants to merge 1 commit into
Open
dedent: stop stripping spaces after a line's first non-space rune#85c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
Closes muesli#44. The dedent loop only marked the leading-space region by toggling shouldOmit on newlines. A line that starts with a non-space rune (e.g. '➜ DKB') stayed in 'strip up to indent' mode, so the space right after the marker also got dropped. Flipping shouldOmit off as soon as we write a non-space rune keeps the intra-line spacing intact. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44.
Closes #72.
The dedent loop only marked the end of a line's leading-space region on newlines, so a line that starts with a non-space rune (e.g.
➜ DKBorThis is an example) stayed in "strip up toindent" mode and the space right after the first rune got dropped along with the leading whitespace from sibling lines.Flipping
shouldOmitoff as soon as we write a non-space rune keeps the intra-line spacing intact while still trimming the shared leading indent on indented lines. Regression test included.