fix(wordwrap): don't break words at non-breaking space (U+00A0)#87
Open
toller892 wants to merge 1 commit into
Open
fix(wordwrap): don't break words at non-breaking space (U+00A0)#87toller892 wants to merge 1 commit into
toller892 wants to merge 1 commit into
Conversation
unicode.IsSpace returns true for non-breaking space (NBSP, U+00A0), which caused the word wrapper to incorrectly treat NBSP as a word boundary. NBSP is specifically designed to prevent line breaks between words and should not be treated as a break opportunity. Fixes muesli#49
toller892
pushed a commit
to toller892/hermes-oss-bug-hunter
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
unicode.IsSpacereturnstruefor non-breaking space (NBSP, U+00A0), which causes the word wrapper to incorrectly treat NBSP as a word boundary. This means text containing NBSP gets wrapped at those positions, defeating the purpose of NBSP which is specifically designed to prevent line breaks.See: https://pkg.go.dev/unicode#IsSpace — NBSP (U+00A0) is included in the set.
Fixes #49
Fix
Add
c != '\u00a0'check alongsideunicode.IsSpace(c)in the word-wrapping logic. This preserves wrapping behavior for all other Unicode space characters while correctly treating NBSP as a non-breaking character.Testing
Added two test cases:
All existing tests continue to pass.