[select][autocomplete] Fix iOS group scrollbar overflow#4727
Open
oliviertassinari wants to merge 1 commit into
Open
[select][autocomplete] Fix iOS group scrollbar overflow#4727oliviertassinari wants to merge 1 commit into
oliviertassinari wants to merge 1 commit into
Conversation
oliviertassinari
added
the
component: select
oliviertassinari
requested review from
flaviendelangle and
michaldudak
as code owners
oliviertassinari
added
the
component: autocomplete
2 tasks
oliviertassinari
added
browser: Safari
commit: |
Bundle size
PerformanceTotal duration: 1,154.40 ms ▼-208.78 ms(-15.3%) | Renders: 53 (+0) | Paint: 1,767.98 ms ▼-315.79 ms(-15.2%)
…and 7 more — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Member
|
As you said, all of the demos are being reworked and should land soon-ish, so it doesn't make much sense to work on this. I'll make sure to check this before merging the new demos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I'm not sure it makes sense to touch those demos since they are being reworked on https://x.com/colmtuite/status/2044408195737608217. But those issues are evergreen; they would apply to any kind of
design. It's about fixing those cut scrollbars:
https://base-ui.com/react/components/select#grouped
https://base-ui.com/react/components/autocomplete#grid-layout
Solution
For the components that are meant to be the starting point: use margin, like some of them already do
For the components that are meant to be more "finished", use isolation as conflict risks are lower and design fidelity is higher.
Context
As for why I worked on this, I'm trying to use this to illustrate where I think we should place the cursor for how far to go when we are working on problems, in this case: mui/material-ui#48375 (comment).