[tabs] Introduce the LinkTab part#4733
Conversation
michaldudak
requested review from
LukasTy,
colmtuite and
flaviendelangle
as code owners
michaldudak
added
the
type: new feature
commit: |
Bundle size
PerformanceTotal duration: 1,251.54 ms ▼-97.33 ms(-7.2%) | Renders: 53 (+0) | Paint: 1,950.18 ms ▼-125.55 ms(-6.0%)
…and 7 more — details Check out the code infra dashboard for more information about this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a973996d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
mj12albert
left a comment
mj12albert
left a comment
There was a problem hiding this comment.
Codex review reports that <Tabs.LinkTab target="_blank"> would open in a new browser tab but onTabActivation still runs, causing the "selected tab" to be inaccurate. Same with the download attribute, but I think both seem useless in the context of Tabs, maybe we could omit them from the types
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0254c2cba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 541d92c415
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Chill out with this until we discuss more please |
3 participants
Added the
Tabs.LinkTabpart to render tabs as<a>elements (or router components wrapping the<a>element).Removed the previous guidance for rendering anchors with
<Tabs.Tab render={<a />} nativeButton={false}>, but this possibility still exists (so it's not a breaking change).Examples of this pattern in real applications
Preview
Docs: https://deploy-preview-4733--base-ui.netlify.app/react/components/tabs#links
React Router experiment: https://deploy-preview-4733--base-ui.netlify.app/experiments/tabs/react-router-link-tabs