[navigation menu] Fix keepMounted content sizing#4817
Open
atomiks wants to merge 1 commit into
Open
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,108.90 ms +16.74 ms(+1.5%) | Renders: 50 (+0) | Paint: 1,699.46 ms +35.68 ms(+2.1%)
11 tests within noise — details Check out the code infra dashboard for more information about this PR. |
atomiks
added
the
type: bug
ChatGPT Codex Connector
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
added
the
component: navigation menu
ChatGPT Codex Connector
atomiks
force-pushed
the
codex/navigation-menu-keep-mounted-sizing
branch
from
aa9420c to
5523947
Compare
atomiks
force-pushed
the
codex/navigation-menu-keep-mounted-sizing
branch
from
5523947 to
245b179
Compare
atomiks
requested review from
LukasTy,
colmtuite,
flaviendelangle and
michaldudak
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<NavigationMenu.Content keepMounted>could transition the size of the popup on open incorrectly + fail to transition the popup dimensions when hovering over nested inline submenus.Root cause
Kept-mounted content can stay in the DOM while inactive, so it must not keep or regain ownership of the shared content ref used for popup sizing.
Before: https://stackblitz.com/edit/dwjmyhms
After: https://stackblitz.com/edit/dwjmyhms-hwgbd7w8
<NavigationMenu.Portal keepMounted>was one workaround before. Though that has a bug with the arrow transitioning (separate issue to fix)Changes
hiddenchanges and defer the first nested-content opening measurement so the popup uses the final nested content size.