[otp field] Prevent locked hidden autofill validation#4827
Open
lunaxislu wants to merge 1 commit into
Open
Conversation
lunaxislu
requested review from
LukasTy,
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
commit: |
Bundle size
PerformanceTotal duration: 1,007.49 ms ▼-438.43 ms(-30.3%) | Renders: 50 (+0) | Paint: 1,514.09 ms ▼-674.76 ms(-30.8%)
…and 5 more (+2 within noise) — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4828.
Follow-up to #4806 and #4810.
#4806 added a locked-state guard to OTP Field's hidden autofill input, but when the component is wrapped in
Field.Root, the merged Field validationonChangecan still run after the OTP Field handler returns. This can clear existing Form errors or commit validation while the field isreadOnlyordisabled.This PR calls
event.preventBaseUIHandler?.()before returning from the locked hidden-input autofill path, matching the Select, Combobox, and NumberField handling from #4810.The tests now cover the locked-state matrix for hidden-input autofill:
readOnly/disabledField.Root/ outsideField.RootThe outside-Field cases keep asserting that OTP Field public callbacks are not called. The inside-Field cases additionally assert that existing
Field.Errorcontent is preserved.Verified with:
pnpm test:jsdom OTPField --no-watchpnpm typescript