use native page size instead of hardcoded 4096 block size#11
Open
souvik1997 wants to merge 1 commit intomultikernel:mainfrom
Open
use native page size instead of hardcoded 4096 block size#11souvik1997 wants to merge 1 commit intomultikernel:mainfrom
souvik1997 wants to merge 1 commit intomultikernel:mainfrom
Conversation
Replace all hardcoded DAXFS_BLOCK_SIZE (4096) references with the native page size queried at mkfs time via sysconf(_SC_PAGESIZE) and validated at mount time against PAGE_SIZE. This enables daxfs to work correctly on architectures with non-4K pages (e.g. 16K on Apple Silicon). Key changes: - mkdaxfs: detect native page size at runtime, store in superblock - mount: validate superblock block_size matches kernel PAGE_SIZE - overlay/pcache/validate: use info->block_size instead of DAXFS_BLOCK_SIZE - daxfs_format.h: bump version to 8, flexible-array for ovl_data_entry - tests: use runtime page size instead of hardcoded 4096
Contributor
|
If I understand it correctly, we also have to replace all the PAGE_SIZE with ->block_size in file.c ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all hardcoded DAXFS_BLOCK_SIZE (4096) references with the native page size queried at mkfs time via sysconf(_SC_PAGESIZE) and validated at mount time against PAGE_SIZE. This enables daxfs to work correctly on architectures with non-4K pages (e.g. 16K on Apple Silicon).
Key changes:
Fixes: #10