Workspace Fork #308
Merged
Workspace Fork #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for multinet-client ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced May 9, 2025
JackWilb
requested changes
May 15, 2025
Comment on lines
285
to
289
| // handle the loading state from child emits function | ||
| function handleLoading(newLoading: boolean) { | ||
| loading.value = newLoading; | ||
| } | ||
Member
There was a problem hiding this comment.
I think this might conflict with the boolean value getting set elsewhere (i.e. if this sets to false, but the other is loading, we will not see the loader while it's still loading). We need 2 booleans here and the loading should be an OR over them both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #307
Give a longer description of what this PR addresses and why it's needed
This PR adds the ability to fork a workspace provided the user has access to the workspace.
The fork option is found under the workspace menu options.
Once forked, the user will be redirected to the new workspace.
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
TODOs: