implemented direct sent transactions cache #7527
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7527 +/- ##
=============================================================
+ Coverage 77.61% 77.62% +0.01%
=============================================================
Files 874 874
Lines 119995 120066 +71
=============================================================
+ Hits 93131 93199 +68
+ Misses 20762 20756 -6
- Partials 6102 6111 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sstanculeanu
changed the base branch from
feat/supernova-async-exec
to
fixes-async-exec
…hain-go into direct-sent-transactions-cache
sstanculeanu
changed the base branch from
fixes-async-exec
to
fix-bootstrap-meta
…-chain-go into direct-sent-transactions-cache
…hain-go into direct-sent-transactions-cache
| return true | ||
| } | ||
|
|
||
| func (sr *subroundBlock) sendDirectSentTransactions( |
There was a problem hiding this comment.
do we need this kind of feature ? The answer is probably yes, as this open up possibilities of private pools, and different mechanics for that.
I wonder whether there is a moment, earlier than this, in which the broadcasting can happen.
|
|
||
| // Save will save the received data into the cacher | ||
| func (txip *TxInterceptorProcessor) Save(data process.InterceptedData, peerOriginator core.PeerID, _ string) (bool, error) { | ||
| func (txip *TxInterceptorProcessor) Save(data process.InterceptedData, peerOriginator core.PeerID, _ string, broadcastMethod p2p.BroadcastMethod) (bool, error) { |
There was a problem hiding this comment.
can't you find some better method on doing this. Like having broadcast method pushed on interceptor.save does not look good.
Also, we have peerOriginator which is used only for printing out the trace.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?