Skip to content

Avido/feature request multiple shipments#47

Open
avido wants to merge 6 commits intomvdnbrk:mainfrom
avido:avido/feature-request-multiple-shipments
Open

Avido/feature request multiple shipments#47
avido wants to merge 6 commits intomvdnbrk:mainfrom
avido:avido/feature-request-multiple-shipments

Conversation

@avido
Copy link
Copy Markdown
Contributor

@avido avido commented Nov 24, 2020

Description

Added batch request for multiple shipments.

Motivation and context

To prevent overhead / multiple calls for a batch of shipments, added batch request.
Chosen to add new methods to keep old method in tact.

Ref: #45

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • [] Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change requires a change to the documentation, I have updated it accordingly.
  • My code follows the code style of this project.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant