Adds support for nested elements named 'class'#118
Open
Confusion wants to merge 1 commit intomvz:masterfrom
Open
Adds support for nested elements named 'class'#118Confusion wants to merge 1 commit intomvz:masterfrom
Confusion wants to merge 1 commit intomvz:masterfrom
Conversation
Defining an item named 'class', as in
```
class Msg
include HappyMapper
has_one :'class', String
end
Msg.parse('<msg></msg>')
```
currently fails with
`lib/happymapper.rb:489:in `initialize': undefined method `attributes' for nil:NilClass (NoMethodError)`
The reason is that the .class method of the HappyMapper object is
overridden and all uses of self.class, starting with the one in
`initialize`, will fail.
The spec modification in this commit demonstrates another aspect of this
problem (when applied without the other changes) and can serve as a guard
against regression.
The fix is to add __class__ as an alias of class. Of course, if anyone ever
needs __class__ as an item, they will run into the same problem.
However, a generic solution adds a lot more complexity and needing __class__
is (much?) less likely than 'class'.
Pull Request Test Coverage Report for Build 76
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defining an item named 'class', as in
currently fails with
lib/happymapper.rb:489:ininitialize': undefined methodattributes' for nil:NilClass (NoMethodError)The reason is that the .class method of the HappyMapper object is
overridden and all uses of self.class, starting with the one in
initialize, will fail.The spec modification in this commit demonstrates another aspect of this
problem (when applied without the other changes) and can serve as a guard
against regression.
The fix is to add
__class__as an alias of class. Of course, if anyone everneeds
__class__as an item, they will run into the same problem.However, a generic solution adds a lot more complexity and needing
__class__is (much?) less likely than 'class'.