GNOME 42 - possible fix for dropdowns for some users#7
Open
Coda-Coda wants to merge 2 commits intomwilck:GNOME-42from
Open
GNOME 42 - possible fix for dropdowns for some users#7Coda-Coda wants to merge 2 commits intomwilck:GNOME-42from
Coda-Coda wants to merge 2 commits intomwilck:GNOME-42from
Conversation
…rom a module must be defined with 'var'`. The full error is: ``` Some code accessed the property 'ArgosMenuItem' on the module 'menuitem'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway. ``` The menu doesn't seem to open without this change.
Author
|
I have not tested this on any version other than GNOME 42. |
mwilck
reviewed
Apr 13, 2022
Owner
mwilck
left a comment
mwilck
left a comment
There was a problem hiding this comment.
This patch shouldn't be necessary. My code uses Utilities.makeSimpleClass(), which maps to GObject.registerClass() for Shell 3.36 and newer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I mentioned, your pull request works fine for me for dropdowns, however perhaps this is still useful for some users who are apparently experiencing issues. As you can see almost all the changes are by @rammie (from https://github.com/rammie/argos/tree/gnome-3.36).
Thanks for your efforts to keep Argos alive 🙂.