Conversation
AlexKERNEL
commented
Feb 26, 2021
AlexKERNEL
commented
- added "-c" parameter for show clean result of "listdir", "listdir_r", "show_f".
- described all parameters in help.
- described all parameters in readme.
- updated Windows binary.
+ added "-c" parameter for show clean result of "listdir", "listdir_r", "show_f". + described all parameters in help. + described all parameters in readme. + updated Windows binary.
ShawnCZek
left a comment
ShawnCZek
left a comment
There was a problem hiding this comment.
I'm not really a maintainer of this repository, but I noticed a few minor issues.
Moreover, this pull request does not seem to follow the code convention.
| **This is Open-Source software under GNU LGPL License.** | ||
|
|
||
| --- Copyright © 2017 Michał Wójtowicz a.k.a. mwl4 --- | ||
| --- Copyright © 2021 Michał Wójtowicz a.k.a. mwl4 --- |
There was a problem hiding this comment.
The copyright year should stay the same.
There was a problem hiding this comment.
Then maybe 2017-2024?
I'm not claiming anything. Each author decides for himself.
| printf("\n" | ||
| " ******************************************\n" | ||
| " ** Converter PMX to PIX **\n" | ||
| " ** Copyright (C) 2021 mwl4 **\n" |
There was a problem hiding this comment.
The copyright year should stay the same.
There was a problem hiding this comment.
Already answered above. I don't see any problems. I wanted the best.
|
|
||
| if (clean_result && mode != LIST_DIR && mode != SHOW_FILE) clean_result = false; | ||
|
|
||
| if (!clean_result) print_copyright(); |
There was a problem hiding this comment.
Copyright should not be optional, in my opinion. Up to @mwl4.
There was a problem hiding this comment.
This is that external parsers get a guaranteed clean result, without trying to separate the copyright from the output data.
2 participants
