Skip to content

fix: size and position of touch indicator and checkbox #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codingLogan merged 1 commit into from
Jan 26, 2026
Merged

fix: size and position of touch indicator and checkbox #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/ExampleCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const ExampleCheckbox: React.FC<
}
> = ({ id, showTouchIndicator, pseudoFocusColor }) => {
const theme = useTheme()
const checkboxSize = '1em'
const checkboxSize = '15px'

return (
<div aria-hidden="true" style={{ position: 'relative' }}>
Expand All @@ -25,14 +25,15 @@ export const ExampleCheckbox: React.FC<
marginTop: '8px',
marginBottom: '8px',
marginRight: '12px',
marginLeft: '4px',
width: checkboxSize,
height: checkboxSize,
}}
tabIndex={-1}
type="checkbox"
/>
{/* Position the touch indicator to be centered over the checkbox */}
{showTouchIndicator && <TouchIndicator style={{ left: '-9px', top: '-4px' }} />}
{showTouchIndicator && <TouchIndicator style={{ left: '-8px', top: '-4px' }} />}
{/* If we are showing the psuedo touch indicator, also show the pseudo-focus for the checkbox */}
{showTouchIndicator && (
<div
Expand Down
4 changes: 2 additions & 2 deletions src/components/TouchIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ export const TouchIndicator: React.FC<React.HTMLAttributes<HTMLDivElement>> = ({

const styles: React.CSSProperties = {
position: 'absolute',
height: '36px',
width: '36px',
height: '37px',
width: '37px',
background: `radial-gradient(circle, ${hover} 0%, ${selected} 100%)`,
stroke: theme.palette.divider,
filter: 'drop-shadow(0 2px 8px rgba(0, 0, 0, 0.12))',
Expand Down
8 changes: 4 additions & 4 deletions src/views/oauth/experiments/PredirectInstructions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ function PredirectInstructions(
const isLastItem = index === checkboxItems.length - 1

return (
<>
<li key={item}>
<React.Fragment key={item}>
<li>
<ExampleCheckbox
id={item}
pseudoFocusColor={institutionColor}
Expand All @@ -139,8 +139,8 @@ function PredirectInstructions(
</Text>
</li>

{!isLastItem && <Divider key={`divider-${index}`} />}
</>
{!isLastItem && <Divider />}
</React.Fragment>
)
})}
</ul>
Expand Down
Loading