Migrate Kyper ChevronRight Icon to MXUI - #357
Open
mwclemy wants to merge 10 commits into
Open
Conversation
mwclemy
requested review from
Jameson13B,
ash-wright123,
codingLogan and
wesrisenmay-mx
as code owners
July 29, 2026 18:22
platypus801
reviewed
Jul 30, 2026
platypus801
reviewed
Jul 30, 2026
platypus801
reviewed
Jul 30, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
platypus801
reviewed
Aug 3, 2026
| > | ||
| {__('Other available data')} | ||
| <ChevronRight style={styles.chevron} /> | ||
| <Icon name="chevron_right" size={16} sx={{ ml: 0.5 }} /> |
Collaborator
Author
There was a problem hiding this comment.
This icon is inside a Link component which is already a flex row.
| > | ||
| {__('Data requested')} | ||
| <ChevronRight style={styles.chevron} /> | ||
| <Icon name="chevron_right" size={16} sx={{ marginLeft: 0.5 }} /> |
| {_p('connect/disclosure/policy/link', 'MX Privacy Policy')} | ||
|
|
||
| <ChevronRight style={styles.chevron} /> | ||
| <Icon name="chevron_right" size={16} sx={{ marginLeft: 0.5 }} /> |
| > | ||
| <PoweredByMXText /> | ||
| <ChevronRight style={styles.chevron} /> | ||
| <Icon name="chevron_right" size={24} sx={{ marginLeft: '6px' }} /> |
Collaborator
Author
There was a problem hiding this comment.
Same here. It's inside a Button that's a centered flex row out of the box.
| styleOverrides: { | ||
| // MUI sizes icon slot children off the button size (medium 20px, large 22px), | ||
| // which beats the Icon's own size prop. Our chevrons are always 24px. | ||
| endIcon: { |
Collaborator
There was a problem hiding this comment.
If we are choosing to change this, then shouldn't we change it at the MXUI level? @platypus801
Collaborator
Author
There was a problem hiding this comment.
I can make this a local fix instead of a global one. I added it to the global override because both places using endIcon currently need it to be 24px, so it seemed reasonable to handle it globally.
The issue occurs when you set the endIcon size differently from MUI’s default icon size for the button (18/20/22px for small/medium/large). MUI’s size takes precedence, so you end up with 20px instead of the 24px you want. To me, this feels more like an MUI issue than an MXUI issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before(Kyper)
After(MXUI)