Fix offline setting not being respected #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34: The
offlineconfiguration setting and--offlineCLI flag are now properly respected to prevent VCS fetch/update operations.Current Status: Demonstrating the Bug
Failing Test
The first commit adds
test_offline_prevents_vcs_operations()that demonstrates the issue:Test scenario:
offline=TrueError:
The test shows that "bar" was fetched even though
offline=Truewas set.Root Cause
There are two separate bugs that both need fixing:
Bug #1: main.py ignores offline configuration (line 92)
Problem: Only checks
--no-fetchCLI flag, completely ignores the configuration'sofflinesetting.What happens:
offline = truein mx.ini → fetch() is still called--offlineCLI flag → sets config offline=true, but fetch() is still called--no-fetchCLI flag actually skips fetch()Bug #2: processing.py hardcodes offline=False (line 201)
Problem: Even if we fix Bug #1, the
fetch()function itself passesoffline=Falsehardcoded.Next Steps
Test Plan