This repository was archived by the owner on Mar 23, 2021. It is now read-only.
Conversation
Instead of injecting the concrete type `Droplet`, use `ClientFactoryProtoco` instead. This applied to; - GitHub client - Travis CI - SlackClient - Bob
Conform to `ConfigInitializable` protocol to allow of initialization with `Config` inline with Vapor documentation. Following conformance implementation were added, - Bob - TravisCI - GitHub
i-dama
reviewed
Jan 25, 2018
Contributor
i-dama
left a comment
There was a problem hiding this comment.
Great PR, thanks for your contribution 👍
Do you think it would make sense to move the config name "bob" into a constant?
Contributor
|
Hi @mosamer , many thanks for your PR 🎊 WDYT? |
Author
|
Hi @vincentaudoire, thanks for the review. I understand your security concerns but I feel they are already addressed.
|
vincentaudoire
approved these changes
Jan 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for initializing Bob, TravisCI and GitHub using Vapor configs. This allows an initialization process that is more inline with other Vapor projects and tutorials.