Open
Conversation
Supports multiple controllers, wip rumble in menus
MegaMech
reviewed
Sep 22, 2025
|
|
||
| courseTimeTrialRecordsPtr->checksum = checksum_time_trial_records(arg0); | ||
| #if ENABLE_RUMBLE | ||
| //block_until_rumble_pak_free(); |
Collaborator
There was a problem hiding this comment.
Why the if with commented out funcs?
Collaborator
|
lgtm, The only thought is whether or not the PR should have a bit more rumbly stuff impl or not? If possible maybe running into wall? I can show where that is. |
Author
|
I'd gladly finish the implementation, however I do not have a physical Rumble Pak (yet) so I can't really fine tune it atm. |
Collaborator
|
Fair enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included is a sample implementation of Rumble Pak support for up to 4 players.
It uses the general structure of SM64's Shindou update with updated code to properly handle multiple controllers separately.
Current code rumbles on menu select and boosting, but other in-game events can easily be added in the future with hardware testing.