fix: resolve VS Code problems in polychro#47
Merged
Conversation
- Suppress the intentional deprecation warning in FunctionRegistryTest where the test deliberately exercises the deprecated FunctionProvider.functions() default to verify backward-compat behavior. - README: drop stray blank line between badges and bump architecture diagram width to 800px for consistency. No source/runtime behavior change; clean `mvn test-compile` on polychro-ruleset confirms zero deprecation warnings.
eskenazit
force-pushed
the
fix/polychro-vscode-problems
branch
from
826cb76 to
b7cc65b
Compare
eskenazit
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the outstanding VS Code "Problems" reported in the Polychro repo and includes a small README cleanup.
Changes
Fix the only VS Code problem in Polychro
FunctionRegistryTest.functionProviderDefaultsToNoFunctionswas flagged with:That call is intentional — the test verifies the backward-compatibility default of the deprecated
FunctionProvider.functions()(and that the context-awarefunctions(Path, List)default delegates to it). Rather than remove the coverage, the test method is now annotated with@SuppressWarnings("deprecation")and a clarifying comment, so the warning is silenced while the legacy contract stays under test.README cleanup
700to800for visual consistency with the other diagrams.Verification
mvn -pl polychro-ruleset -am test-compile→ BUILD SUCCESS with zero deprecation warnings.Notes
No source or runtime behavior changes — this is a warning-hygiene + docs cleanup PR.