perf: optimize shared-kernel-rs utilities#12
Open
Magizhan wants to merge 1 commit into
Open
Conversation
- Optimize Redis command implementations - Improve middleware request handling - Add performance benchmarks - Fix clippy warnings - cargo fmt clean Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared-kernel-rs library had several performance inefficiencies and code quality issues: unnecessary string allocations in error handling, uncompiled regex patterns evaluated on every call, redundant
format!()wrappers, deprecated AWS SDK usage, and missing inline hints on hot-path utility functions. Additionally, there were no performance benchmarks to catch regressions.Solution
Performance Optimizations
once_cell::sync::Lazyin middleware utils (eliminates re-compilation per request)&'static strfor error codes —code()returns static strings instead of allocatingStringon every error#[inline]hints on hot-path functions:get_method(),get_headers(),Derefimpl, error helpers.first()instead of.get(0),to_owned()overto_string()for&str, direct string clones instead of format wrappers#[serde(skip_serializing_if)]to avoid serializing empty optional fieldsCode Quality
aws_config::from_env()→aws_config::defaults(BehaviorVersion::latest())log::info,tracing::*,UnboundedReceiver,UnboundedSender)measure_durationnow preserves function attributes (#[allow(...)],#[cfg(...)])ErrorHandler<E>type alias for readability in callapi moduleBenchmarks
Testing
cargo buildpassescargo clippycleancargo testpassescargo benchImpact