backend/fix/offer-auto-apply

[yashikakaushik]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates

Description

Additional Changes

• This PR modifies the database schema (database migration added)
• This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

• I formatted the code and addressed linter errors ./dev/format-all-files.sh
• I reviewed submitted code
• I added unit tests for my changes where possible
• I added a CHANGELOG entry if applicable

Summary by CodeRabbit

• Refactor
  • Updated internal payment parsing logic to improve type consistency and maintainability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 31774f94-f0a9-44f0-b3ca-01aa0ccb4295

📥 Commits

Reviewing files that changed from the base of the PR and between 3d52237 and 69625c4.

📒 Files selected for processing (1)

• lib/mobility-core/src/Kernel/External/Payment/Juspay/Types/Offer.hs

---

Walkthrough

A helper function's parameter type is updated from Text to Aeson's Key in the FromJSON OfferUIConfigs parser, maintaining existing parsing logic for optional boolean fields.

Changes

Cohort / File(s)	Summary
Aeson Key Type Signature lib/mobility-core/src/Kernel/External/Payment/Juspay/Types/Offer.hs	Updated parseMaybeBoolField helper function second parameter type from Text to Aeson's Key to align with JSON object key handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A key changed its shape from text to Key,
In parsing land, a modest spree,
The booleans still flow the same old way,
A type-safe hop to brighter day! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The PR title 'backend/fix/offer-auto-apply' is vague and uses a generic naming convention (path/type/description format) without clearly conveying what the actual change accomplishes. The title does not explain the specific technical modification (parameter type change from Text to Key) or the purpose of the fix.	Provide a more descriptive title such as 'Update parseMaybeBoolField parameter type to use Aeson Key' to clearly communicate the main technical change being made.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch backend/fix/offer-auto-apply

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}