Skip to content

backend/enhancement/added-new-mandate-statuses#1284

Open
dushyant-2002 wants to merge 1 commit into
mainfrom
backend/enhancement/added-new-mandate-statuses
Open

backend/enhancement/added-new-mandate-statuses#1284
dushyant-2002 wants to merge 1 commit into
mainfrom
backend/enhancement/added-new-mandate-statuses

Conversation

@dushyant-2002
Copy link
Copy Markdown
Contributor

@dushyant-2002 dushyant-2002 commented May 12, 2026

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Summary by CodeRabbit

  • New Features
    • Extended payment mandate status options to support additional states in the payment lifecycle. Two new statuses (pause pending and revoke pending) are now available for improved mandate management and tracking.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 240d4286-5788-4224-99e1-241f93115d83

📥 Commits

Reviewing files that changed from the base of the PR and between 977129c and ee091ad.

📒 Files selected for processing (1)
  • lib/mobility-core/src/Kernel/External/Payment/Juspay/Types/Common.hs

Walkthrough

This PR extends the MandateStatus type in the Juspay payment integration layer by adding two new constructors (PAUSE_PENDING and REVOKE_PENDING) to represent intermediate states during mandate lifecycle operations. The existing status constructors remain unchanged.

Changes

Mandate Status States

Layer / File(s) Summary
Extend MandateStatus with pending states
lib/mobility-core/src/Kernel/External/Payment/Juspay/Types/Common.hs
MandateStatus enum expanded with PAUSE_PENDING and REVOKE_PENDING constructors to model transient states during pause and revoke operations, preserving all existing status values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through payment states so fine,
New pending flags now draw a clearer line,
Pause and revoke can wait their turn with grace,
Two states arrive to join the mandate race! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: adding new mandate statuses (PAUSE_PENDING and REVOKE_PENDING) to the MandateStatus data type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backend/enhancement/added-new-mandate-statuses

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant