You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 30, 2024. It is now read-only.
'time.time_ns()' method is new in Python version 3.7 .
Therefore, testing in Python 3.6 resulted in an error message, stating that the module 'time' has no attribute 'time_ns()'.
As your Timer module only displays ms, I changed the code, so that it can be used in Python 3.6.
This issues occurred in a Colab VM and the fix has been successfully tested there.
Additionally, I added the vscode directory to the gitignore for obvious dev. purposes.
Hi @stroblme, thank you for the contribution but unfortunately bitpanda-aio is no longer actively maintained as advised at the beginning of the repo's front page. bitpanda-aio was replaced by cryptoxlib-aio where is my primary focus now. It should provide the same functionality and on top many more features.
I can merge your PR but I will first need to find some time to give it at the least a minimum testing (despite the fix is straightforward). Besides that, no new pypi packages will be generated.
Hi @nardew , sorry for the late response. In my case I started the project where I used bitpanda-aio some time ago, when I wasn't aware of cryptoxlib-aio. Maybe I should change that by now.. Anyway, I get your point and as I don't see this PR as really urgent, feel free to reject :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'time.time_ns()' method is new in Python version 3.7 .
Therefore, testing in Python 3.6 resulted in an error message, stating that the module 'time' has no attribute 'time_ns()'.
As your Timer module only displays ms, I changed the code, so that it can be used in Python 3.6.
This issues occurred in a Colab VM and the fix has been successfully tested there.
Additionally, I added the vscode directory to the gitignore for obvious dev. purposes.