Fix fixed-mixture density for condensed reactants - #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix non-finite density and volume results when
Mixture.calc_propertyis called for liquid or other condensed reactants before equilibrium analysis.Changes
The CH4(L)/O2(L) reproduction now returns
2.251e-01 g/ccinstead of a non-finite value.Testing
ctest -R 'cea_core_test' -Vpytest source/bind/python/tests— 68 passedCompatibility / Numerical behavior
Fixed-mixture density and volume results now include condensed reactants and are finite. Multi-temperature density and volume results also receive the same unit scaling as the single-temperature path.