Fix frozen indices - #99
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix frozen rocket scheduling when
n_frzfalls inside a multi-point exit schedule, restoring parity with legacy CEA2 forn_frz=3and higher. Closes #95 .Also add experimental
n_frz=-1support to expand the supplied reactant composition through the nozzle without performing any equilibrium solves.Changes
Split IAC and FAC
pi_pandsuparschedules into:Preserve the freeze-station composition at every downstream frozen point.
Add an experimental
n_frz=-1mode that:EqSolver.solvecalls.pi_p,subar, andsuparschedules.n_frzto positive values.Prevent negative composition indexing in command-line frozen output.
Testing
n_frz=3issue.1e-5relative tolerance.Compatibility / Numerical behavior
Numerical results change for freeze boundaries that previously occurred inside a multi-point
pi_porsuparschedule. These cases now transition from equilibrium to frozen composition at the requested station and match legacy CEA2 behavior.n_frz=-1introduces new experimental numerical behavior with no CEA2 equivalent: reactants are expanded with fixed composition and no equilibrium solves.