Skip to content

EDSC-4664: Upgrade to node lts/krypton#129

Merged
eudoroolivares2016 merged 3 commits into
mainfrom
EDSC-4664
May 29, 2026
Merged

EDSC-4664: Upgrade to node lts/krypton#129
eudoroolivares2016 merged 3 commits into
mainfrom
EDSC-4664

Conversation

@eudoroolivares2016

@eudoroolivares2016 eudoroolivares2016 commented May 26, 2026

Copy link
Copy Markdown
Contributor

Overview

What is the feature?

Upgrades to node lts/krypton and bumps dependencies

What is the Solution?

Upgrading the CI and the nvm to use node 24 long term. Here we are also removing node-sass. node-sass is a C++ native addon, so it uses node-gyp to compile during install. node-gyp relies on Python's distutils module — but distutils was removed in Python 3.12 https://nodejs.org/learn/node-api/build-tools/node-gyp this one relies on this https://peps.python.org/pep-0632/ which is gone on 3.12 so that is why this fails to reconcile the c++ plugin will fail to complile when doing the npm install but, its not needed since node-sass is just a peerdependency for sass-loader and so we just need one of those. In this case we already use sass package which is javascript native and thus doesn't have this issue

What areas of the application does this impact?

All areas

Testing

Reproduction steps

  1. Regression test this using the example in the repository or run npm pack and pull the tar into local EDSC to regression test there

Attachments

image

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • [NA] I have commented my code, particularly in hard-to-understand areas
  • [NA] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have bumped the version field in package.json and ran npm install

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.54%. Comparing base (2d8462d) to head (860af2c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          43       43           
  Lines         935      935           
  Branches      228      227    -1     
=======================================
  Hits          912      912           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread babel.config.js Outdated
esmodules: true
node: '24',
esmodules: true,
ie: '10'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ie 10?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase mistake now removed

@eudoroolivares2016 eudoroolivares2016 merged commit 87f2918 into main May 29, 2026
7 checks passed
@eudoroolivares2016 eudoroolivares2016 deleted the EDSC-4664 branch May 29, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants