EDSC-4664: Upgrade to node lts/krypton#129
Merged
Merged
Conversation
28c3e44 to
b8926d5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 43 43
Lines 935 935
Branches 228 227 -1
=======================================
Hits 912 912
Misses 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
macrouch
reviewed
May 27, 2026
| esmodules: true | ||
| node: '24', | ||
| esmodules: true, | ||
| ie: '10' |
Contributor
Author
There was a problem hiding this comment.
rebase mistake now removed
macrouch
approved these changes
May 27, 2026
mandyparson
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Upgrades to node
lts/kryptonand bumps dependenciesWhat is the Solution?
Upgrading the CI and the nvm to use node 24 long term. Here we are also removing node-sass.
node-sassis a C++ native addon, so it usesnode-gypto compile during install.node-gyprelies on Python'sdistutilsmodule — butdistutilswas removed in Python 3.12 https://nodejs.org/learn/node-api/build-tools/node-gyp this one relies on this https://peps.python.org/pep-0632/ which is gone on 3.12 so that is why this fails to reconcile the c++ plugin will fail to complile when doing the npm install but, its not needed since node-sass is just a peerdependency forsass-loaderand so we just need one of those. In this case we already usesasspackage which is javascript native and thus doesn't have this issueWhat areas of the application does this impact?
All areas
Testing
Reproduction steps
npm packand pull the tar into local EDSC to regression test thereAttachments
Checklist