ENH: Add subfigure_mosaic for creating SubFigure layouts#1
Open
ENH: Add subfigure_mosaic for creating SubFigure layouts#1
Conversation
- Refactored subplot_mosaic into shared _do_mosaic private method - Added subfigure_mosaic that creates SubFigure layouts using same syntax - Added comprehensive tests for subfigure_mosaic functionality - Tests verify flat subfigure creation and nested hierarchy support - All 40 existing subplot_mosaic tests still pass Addresses matplotlib#25949 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subfigure_mosaicmethod that creates SubFigure layouts using the same ASCII art or nested list syntax assubplot_mosaicsubplot_mosaicto share implementation via a private_do_mosaicmethodImplementation Details
_do_mosaicwith dependency injection for the child creation methodsubplot_mosaicpassesself.add_subplotas the child creatorsubfigure_mosaicpassesself.add_subfigureas the child creatorsubfigure_mosaicon a SubFigureTesting
TestSubfigureMosaicclassTestSubplotMosaictests still pass without modificationAPI Decisions
sharex/shareyparameters not supported for subfigures (they're containers without axes at creation time)subplot_mosaic- nesting in spec is for layout onlyTest plan
pytest lib/matplotlib/tests/test_figure.py::TestSubfigureMosaicpytest lib/matplotlib/tests/test_figure.py::TestSubplotMosaic🤖 Generated with Claude Code