Skip to content

Update dependencies for newer Rails versions #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p8 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update dependencies for newer Rails versions #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e838898
Update bundler dev dependency for newer Ruby versions
p8 Jun 20, 2026
a790c10
Update Rails development dependency
p8 Jun 20, 2026
1287f0e
Include ::ActiveModel::Conversion on search_class
p8 Jun 20, 2026
ae445cd
Initialize ActionView::Base in test with required arguments
p8 Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/searchlight/adapters/action_view.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ module Searchlight
module Adapters
module ActionView

include ::ActiveModel::Conversion

def self.included(search_class)
search_class.include ::ActiveModel::Conversion
search_class.extend ::ActiveModel::Naming
end

Expand Down
6 changes: 3 additions & 3 deletions searchlight.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_development_dependency "rspec", "~> 3.2"
spec.add_development_dependency "bundler", "~> 1.3"
spec.add_development_dependency "bundler", ">= 2.0"
spec.add_development_dependency "rake"
spec.add_development_dependency "capybara", "~> 2.4"

# To test integration with actionview and activerecord
spec.add_development_dependency "actionview", "~> 4.1"
spec.add_development_dependency "activemodel", "~> 4.1"
spec.add_development_dependency "actionview", "~> 8.1"
spec.add_development_dependency "activemodel", "~> 8.1"
end
2 changes: 1 addition & 1 deletion spec/searchlight/adapters/action_view_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

describe "Searchlight::Adapters::ActionView", type: :feature do

let(:view) { ::ActionView::Base.new }
let(:view) { ::ActionView::Base.with_empty_template_cache.with_view_paths(nil, {}) }
let(:search) { BookSearch.new("title_like" => "Love Among the Chickens") }

before :all do
Expand Down