Updating readme / fixing ExportNamedDeclaration bug#2
Open
dmitrif wants to merge 3 commits intonathanmarks:masterfrom
Open
Updating readme / fixing ExportNamedDeclaration bug#2dmitrif wants to merge 3 commits intonathanmarks:masterfrom
dmitrif wants to merge 3 commits intonathanmarks:masterfrom
Conversation
StevePotter
approved these changes
Nov 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Great job on this plugin, just what I needed. I just added some documentation (following the standard set forth by other babel plugins) as well as fix one bug.
In case of
export default class ComponentName extends React.Component, the plugin would fail as it would not account for the parent being an ExportNamedDeclaration. This takes care of that.Thanks.