fix: nativeStyleMapping#214
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug related to lightningcss@1.30.2 by adding a warning to prevent compilation failures. It also introduces native style mapping functionality and updates test expectations to reflect changes in style merging behavior.
- Adds version check and warning for problematic lightningcss@1.30.2
- Implements native style mapping feature with new
nativeStyleMappingfunction - Updates style merging logic to handle native style mappings and target configurations
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/compiler/lightningcss-loader.ts | Adds version detection and warning for lightningcss@1.30.2 |
| src/native/styles/index.ts | Implements native style mapping function and updates merge logic |
| src/native/react/useNativeCss.ts | Adds nativeStyleMapping support to config generation |
| src/tests/native/specificity.test.tsx | Updates test expectations from arrays to single objects |
| src/tests/native/container-queries.test.tsx | Updates test expectations from arrays to single objects |
| example/src/App.tsx | Adds Button component for testing purposes |
marklawlor
force-pushed
the
10-10-fix_add_warning_for_lightningcss_1.30.2
branch
from
bd3fea7 to
784a1f4
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
marklawlor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.