fix: remove transform keys before appending new ones#357
Closed
5ZYSZ3K wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes duplicated translate-related entries in React Native transform arrays by removing any existing transform objects whose keys will be appended next, preventing compounded transforms when multiple translate classNames are combined (issue #356).
Changes:
- Expands transform cleanup logic to remove existing transform entries not only for the current
prop, but also for any keys present in the incoming transform array value.
Comment on lines
+72
to
+79
| // Remove any existing values and any keys that are to be appended next | ||
| target.transform = transformArray.filter((t) => !(prop in t)); | ||
| const keysToRemove = Array.isArray(value) | ||
| ? new Set(value.flatMap((v) => Object.keys(v))) | ||
| : new Set([prop]); | ||
| target.transform = transformArray.filter( | ||
| (t) => !(prop in t) && !Object.keys(t).some((k) => keysToRemove.has(k)), | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
I applied the suggestions
Comment on lines
+74
to
+79
| const keysToRemove = Array.isArray(value) | ||
| ? new Set(value.flatMap((v) => Object.keys(v))) | ||
| : new Set([prop]); | ||
| target.transform = transformArray.filter( | ||
| (t) => !(prop in t) && !Object.keys(t).some((k) => keysToRemove.has(k)), | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
I added the test, but I realised that it would be passed even without my change - it wasn't enough to capture the regression, but I couldn't find why
Contributor
Author
|
I found another issue: #358, and I guess that it might be necessary to target both of them at once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to remove doubled translate-related objects in the
transformarray, as described in #356Closes #356