Open
Conversation
Collaborator
jefferis
commented
Oct 9, 2023
jefferis
commented
- separate computation of tps xform from applying it
- memoise as well so it only runs once
- much faster for larger/unstable tps pointsets
* separate computation of tps xform from applying it * memoise as well so it only runs once * much faster for larger/unstable tps pointsets
* => change in tpsreg class * will occupy more space - wondering if memoisation might still be a better fit
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
==========================================
- Coverage 76.88% 76.80% -0.08%
==========================================
Files 48 48
Lines 5935 5941 +6
==========================================
Hits 4563 4563
- Misses 1372 1378 +6 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.