fix: vim keys crash with emitKeys error on Node.js v25#15
Merged
Conversation
The previous approach patched stdin.emit and re-emitted synthetic keypress events with partial key objects. In Node.js v25, readline's internal architecture changed such that synthetic keypress events route back through ReadStream.onData → emitKeys generator, crashing on incomplete key data. Fix by intercepting at the raw data layer: replace single-byte vim keys (j/k/g/G/q) with their terminal escape sequences before readline processes them. readline's emitKeys generator receives valid escape sequences and produces correct keypress events naturally. Fixes #14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14
Summary
stdin.emitpatch re-emitted synthetickeypressevents with incomplete key objects; Node.js v25 routes these back throughReadStream.onData → emitKeysgenerator, which crashesdatalayer — replace vim key bytes with terminal escape sequences before readline processes thememitKeysreceives valid sequences and generates correct keypress events naturally, no crashChanges
src/core/vim-keys.ts— switched from keypress interception to data interception:j\u001b[B(↓)k\u001b[A(↑)g\u001b[H(Home)G\u001b[F(End)q\u0003(Ctrl+C)Test plan
npm run build— clean compilenode dist/index.js --help— script mode worksnode dist/index.js events --json— backward compat intactj/knavigation works on Node.js v25