Fix race condition in nextStep on high refresh rate displays #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On high refresh rate displays, nextStep() can be called multiple times before STEP++ executes, since nextStep is called every CLOCK frames, while STEP++ is scheduled by setTimeout. This leads to false WIN triggers in the "Complex-Prevent" puzzle.
Example: The first nextStep() is called. Before its scheduled infect and STEP++ execute, the second nextStep() is called. Then the callbacks run in order: first infect, first STEP++, second infect, second STEP++. Since both infect calls target the same peep, the infection count doesn't change between the two STEP++ increments. However, after the first STEP++, state.lastInfected in the "Complex-Prevent" onupdate is updated. When the second STEP++ triggers another onupdate check, lastInfected == countInfected evaluates to true, falsely triggering the win condition.
Before fix:
before.mp4
After fix:
after.mp4