Inset the corner by 10 pixels instead of 5 #433
Open
blackketter wants to merge 1 commit intonchudleigh:masterfrom
Open
Inset the corner by 10 pixels instead of 5 #433blackketter wants to merge 1 commit intonchudleigh:masterfrom
blackketter wants to merge 1 commit intonchudleigh:masterfrom
Conversation
Collaborator
|
Could you point me to some examples that previously didn't work but now do? |
dexterleng
reviewed
May 6, 2021
| x: element.frame.origin.x + 5, | ||
| y: element.frame.origin.y + element.frame.height - 5 | ||
| // inset from corner by 10 pixels, but no more than halfway | ||
| x: element.frame.origin.x + min(element.frame.width / 2, 10), |
Collaborator
There was a problem hiding this comment.
not overshooting when jumping by a magic number is a great idea
Author
Sorry, should have referenced my last comment in #373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and keep in the lower-left corner. Fixes many cases for me, can't find any examples that are worse.