Add color settings to preference pane#435
Open
blackketter wants to merge 3 commits intonchudleigh:masterfrom
Open
Add color settings to preference pane#435blackketter wants to merge 3 commits intonchudleigh:masterfrom
blackketter wants to merge 3 commits intonchudleigh:masterfrom
Conversation
Collaborator
|
@blackketter I would prefer to just change the hardcoded scroll border color if it's an issue. Less configuration means less code which means less maintenance. I think there certainly is value in letting users configure the color, but I'm not a huge fan of the current scroll mode workflow so things may change in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think of this approach for #371