-
Notifications
You must be signed in to change notification settings - Fork 28
Pratham (Project 1) #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: contributed-notebooks
Are you sure you want to change the base?
Pratham (Project 1) #158
Conversation
Updated Problem Set 4
Added Problem Set 5
Published PS6
adowling2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see minor comments below.
| @@ -9,6 +9,8 @@ | |||
| "# Example of Mass Balance Problem in Wastewater Treatment Units\n", | |||
| "Prepared by Annabelle Li (ali7@nd.edu) and Audrey Hansrisuk (ahansris@nd.edu)\n", | |||
| "\n", | |||
| "Edited by Pratham Singh (psingh4@nd.edu)\n", | |||
| "\n", | |||
| "**Reference:** Chapter 4 in *Elementary Principles of Chemical Processes*, 4th ed., Felder, R.M.; Rousseau, R.W.; Bullard, L.G. (2015), **Question 4.44**\n", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the bold from the question number in the reference
| @@ -9,6 +9,8 @@ | |||
| "# Example of Mass Balance Problem in Wastewater Treatment Units\n", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mass Balance Analysis for Wastewater Treatment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change title to this.
| "plt.show()\n", | ||
| "# Create a publication-quality plot with reduced size\n", | ||
| "plt.figure(figsize=(4, 3), dpi=200) # Set figure size and DPI for a smaller plot\n", | ||
| "plt.plot(m1_values, x6_values, 'bo-', markersize=6, label='x6_Cr') # Use blue circles with a solid line\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use LaTeX here,
| " chromium_cost: Total cost of chromium in the waste stream (USD)\n", | ||
| " \"\"\"\n", | ||
| " # BEGIN SOLUTION\n", | ||
| " if m1 >= 4500:\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need comments to explain this logic. This looks like a bound, but add comments so the reader does not need to guess.
| { | ||
| "cell_type": "markdown", | ||
| "source": [ | ||
| "Assume the value of chromium per kg is $9. Estimate the cost of chromium for different flow rate and the print the cost. Also plot the varying inlet flow vs chromium value in the waste stream." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a reference for this assumption
| "plt.figure(figsize=(4, 3), dpi=200)\n", | ||
| "\n", | ||
| "# Plot the data with a solid red line and circular markers\n", | ||
| "plt.plot(m1_values, chromium_costs, 'r-o', markersize=6, label=\"Chromium Cost\")\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not need a legend because there is one line and the legend label is redundant with the y-axis label.
| { | ||
| "cell_type": "markdown", | ||
| "source": [ | ||
| "Discussion: Is it economically and environmentally worthwhile to recover chromium in the circular economy, given the associated cost of recovery?\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussion: to be consistent with the rest of the notebook
| "source": [ | ||
| "#6. Economic Analysis of Chromium\n", | ||
| "\n", | ||
| "Develop a function ``econ_cr`` to evaluate the cost of the chromium that is going to waste stream when the inlet flow is above 4500 kg/h.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be the value of the Cr lost in the waste stream? Does the $9/kg represent the cost of disposal? Or is it the market value if the Cr could be capture, purified, and sold?
Contributed notebook